This repository was archived by the owner on Nov 7, 2025. It is now read-only.
splitTimeRangeExt is considered harmful #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/run-it |
jakozaur
approved these changes
Jun 10, 2025
avelanarius
added a commit
to avelanarius/quesma
that referenced
this pull request
Jun 10, 2025
Recently, there was a regression caused by a bug in splitTimeRangeExt optimization (see QuesmaOrg#1454), which splits queries with long time ranges. Our unit/integration tests failed to catch the issue. The reproducer for the issue is to run a _search query: sorted by time, over some time range and with a filter. This PR adds a new integration test. This test runs the reproducing query (_search query: sorted by time, over some time range and with a filter), as well as different variations of the query: short/long time range, with/without filter, inclusive/exclusive ends of time range. This should cover the splitTimeRangeExt optimization more thoroughly. There are two types of tests: - testTimerangesHandwritten: handwritten different queries - testTimerangesRandom: randomly generated ranges
avelanarius
added a commit
to avelanarius/quesma
that referenced
this pull request
Jun 10, 2025
Recently, there was a regression caused by a bug in splitTimeRangeExt optimization (see QuesmaOrg#1454), which splits queries with long time ranges. Our unit/integration tests failed to catch the issue. The reproducer for the issue is to run a _search query: sorted by time, over some time range and with a filter. This PR adds a new integration test. This test runs the reproducing query (_search query: sorted by time, over some time range and with a filter), as well as different variations of the query: short/long time range, with/without filter, inclusive/exclusive ends of time range. This should cover the splitTimeRangeExt optimization more thoroughly. There are two types of tests: - testTimerangesHandwritten: handwritten different queries - testTimerangesRandom: randomly generated ranges
nablaone
pushed a commit
that referenced
this pull request
Jun 12, 2025
Recently, there was a regression caused by a bug in `splitTimeRangeExt` optimization (see #1454), which splits queries with long time ranges. Our unit/integration tests failed to catch the issue. The reproducer for the issue is to run a `_search` query: sorted by time, over some time range and with a filter. This PR adds a new integration test. This test runs the reproducing query (`_search` query: sorted by time, over some time range and with a filter), as well as different variations of the query: short/long time range, with/without filter, inclusive/exclusive ends of time range. This should cover the `splitTimeRangeExt` optimization more thoroughly. There are two types of tests: - `testTimerangesHandwritten`: handwritten different queries - `testTimerangesRandom`: randomly generated ranges
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitTimeRangeExtoptimization may break some queries. Let's go ahead and disable it and proceed with further investigation.